Add content script noScriptStartedPostMessage option.#2265
Open
jviney wants to merge 1 commit intowxt-dev:mainfrom
Open
Add content script noScriptStartedPostMessage option.#2265jviney wants to merge 1 commit intowxt-dev:mainfrom
jviney wants to merge 1 commit intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
pkg/wxt
The deprecated `window.postMessage` path for the `wxt:content-script-started` message causes bad interactions with sites that have a poorly implemented event listener. This PR adds an option to exclude the `window.postMessage` event entirely, until such time as WXT completely removes it, which is a breaking change. Related PRs wxt-dev#1938 wxt-dev#2035
jviney
force-pushed
the
add-content-script-noScriptStartedPostMessage-option
branch
from
4319253 to
280df61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The deprecated
window.postMessagepath for thewxt:content-script-startedmessage causes bad interactions with sites that have a poorly implemented event listener. Eg a previously dormant event listener like this is now triggered to become an infinite loop of message passing:This PR adds an option to exclude the
window.postMessageevent entirely, until such time as WXT completely removes it, which is a breaking change.There are two recent PRs that discuss the move away from
window.postMessageto custom events.#1938
#2035
Manual Testing
Checked the postMessage is no longer sent to the window.
Simple reproduction of the issue: